Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

オフライン時の画面にリロードボタンを追加 #11242

Conversation

anatawa12
Copy link
Member

What

オフライン時の画面にリロードボタンを追加する

Why

リロードのためのボタンがないとPWAでインターネットが復帰しても何もできなくなるため。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

リロードのためのボタンがないとPWAでインターネットが復帰しても何もできなくなるため。
@github-actions github-actions bot added the packages/sw and PWA ServiceWorker and PWA related issue/PR label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #11242 (25483f4) into develop (f4d1fca) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11242      +/-   ##
===========================================
+ Coverage    77.67%   77.77%   +0.09%     
===========================================
  Files          908      908              
  Lines        91787    91874      +87     
  Branches      7671     7699      +28     
===========================================
+ Hits         71296    71454     +158     
+ Misses       20491    20420      -71     

see 47 files with indirect coverage changes

@syuilo syuilo merged commit 9845cce into misskey-dev:develop Jul 11, 2023
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 11, 2023

👍🏻

@anatawa12 anatawa12 deleted the add-reload-button-to-service-worker-offline branch July 11, 2023 09:34
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* feat: オフライン時の画面にリロードボタンを追加

リロードのためのボタンがないとPWAでインターネットが復帰しても何もできなくなるため。

* docs(changelog): add オフライン時の画面にリロードボタンを追加
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/sw and PWA ServiceWorker and PWA related issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants