Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): MkAsUi: allow non-center container align #11255

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

hibiyasleep
Copy link
Contributor

@hibiyasleep hibiyasleep commented Jul 12, 2023

What

in options of Ui:C:container of AiScript UI, only align: 'center' works, while align: 'left' | 'center' | 'right'
#11251 for more info.

Why

to close #11251

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #11255 (a865aa8) into develop (b97694b) will increase coverage by 0.17%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11255      +/-   ##
===========================================
+ Coverage    77.65%   77.82%   +0.17%     
===========================================
  Files          908      910       +2     
  Lines        91874    92033     +159     
  Branches      7671     7705      +34     
===========================================
+ Hits         71343    71629     +286     
+ Misses       20531    20404     -127     

see 21 files with indirect coverage changes

@syuilo syuilo merged commit a72ef70 into misskey-dev:develop Jul 13, 2023
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 13, 2023

🙏

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MkAsUi: Ui:C:container: align: 'right' not working
2 participants