Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): solve test failures #11262

Merged
merged 4 commits into from
Jul 12, 2023
Merged

fix(storybook): solve test failures #11262

merged 4 commits into from
Jul 12, 2023

Conversation

saschanaz
Copy link
Member

What

Fixes #11261

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 12, 2023
@saschanaz saschanaz changed the title Fix storybook2 fix(storybook): solve test failures Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #11262 (6de91ff) into develop (cd9affd) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11262      +/-   ##
===========================================
+ Coverage    77.65%   77.69%   +0.04%     
===========================================
  Files          908      910       +2     
  Lines        91874    92033     +159     
  Branches      7670     7672       +2     
===========================================
+ Hits         71341    71509     +168     
+ Misses       20533    20524       -9     

see 4 files with indirect coverage changes

@syuilo syuilo merged commit b6a432f into develop Jul 12, 2023
17 checks passed
@syuilo syuilo deleted the fix-storybook2 branch July 12, 2023 23:41
@syuilo
Copy link
Member

syuilo commented Jul 12, 2023

🙏

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* fix(locales, storybook): use default import

* fix(storybook): solve test failures

* Update MkAd.stories.impl.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storybook UI testが落ちてる
2 participants