Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): add unix socket support #11275

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Conversation

ybw2016v
Copy link
Contributor

What

Add unix socket support, to make it possible to let misskey listen on the unix socket, which may improve backend performance.

Why

The unix socket is an inter-process communication mechanism and it can avoid some unnecessary checks and operations, which makes them faster and lighter than listening on the TCP/IP loopback port if the reverse proxy and misskey are running on the same machine.

Additional info (optional)

https://serverfault.com/questions/124517/what-is-the-difference-between-unix-sockets-and-tcp-ip-sockets

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #11275 (70fb71c) into develop (df54806) will decrease coverage by 0.12%.
The diff coverage is 43.75%.

@@             Coverage Diff             @@
##           develop   #11275      +/-   ##
===========================================
- Coverage    77.84%   77.73%   -0.12%     
===========================================
  Files          917      918       +1     
  Lines        92631    92703      +72     
  Branches      7769     7741      -28     
===========================================
- Hits         72112    72063      -49     
- Misses       20519    20640     +121     
Impacted Files Coverage Δ
packages/backend/src/boot/master.ts 0.00% <0.00%> (ø)
packages/backend/src/server/ServerService.ts 48.61% <33.33%> (-0.98%) ⬇️
packages/backend/src/config.ts 96.46% <100.00%> (+0.03%) ⬆️

... and 18 files with indirect coverage changes

@syuilo syuilo merged commit 5dab918 into misskey-dev:develop Jul 17, 2023
16 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 17, 2023

👍🏻

slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
* unix socket support

* add changelog

* lint

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants