Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Array.from(iterable).map(mapfn)をArray.from(iterable | { length: number }, mapfn)に #11337

Merged
merged 2 commits into from
Jul 25, 2023
Merged

refactor: Array.from(iterable).map(mapfn)をArray.from(iterable | { length: number }, mapfn)に #11337

merged 2 commits into from
Jul 25, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Jul 21, 2023

これ

c9b9db1

@tamaina tamaina marked this pull request as ready for review July 21, 2023 11:19
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #11337 (a495468) into develop (561683f) will decrease coverage by 0.02%.
The diff coverage is 20.00%.

@@             Coverage Diff             @@
##           develop   #11337      +/-   ##
===========================================
- Coverage    77.70%   77.69%   -0.02%     
===========================================
  Files          920      919       -1     
  Lines        92735    92677      -58     
  Branches      7748     7749       +1     
===========================================
- Hits         72064    72008      -56     
+ Misses       20671    20669       -2
Impacted Files Coverage Δ
packages/frontend/src/scripts/emoji-base.ts 30.00% <0.00%> (ø)
packages/frontend/src/scripts/select-file.ts 16.36% <0.00%> (-0.16%) ⬇️
packages/frontend/src/components/MkPostForm.vue 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@tamaina @acid-chicken
Update packages/frontend/src/components/MkTagCloud.vue
a495468 
Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
@tamaina tamaina changed the title refactor: Array.from(iterable).map(mapfn)をArray.from(iterable, mapfn)に refactor: Array.from(iterable).map(mapfn)をArray.from(iterable | { length: number }, mapfn)に Jul 21, 2023
@acid-chicken acid-chicken merged commit fe13755 into develop Jul 25, 2023
17 checks passed
@acid-chicken acid-chicken deleted the afmf branch July 25, 2023 10:46
@tai-cha tai-cha mentioned this pull request Jul 31, 2023
Merged
5 tasks
@tamaina tamaina mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acid-chicken acid-chicken acid-chicken approved these changes

@syuilo syuilo Awaiting requested review from syuilo

Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamaina @acid-chicken