Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 著作権とライセンスについての情報を各ファイルに追加する #11348

Merged

Conversation

sorairolake
Copy link
Contributor

@sorairolake sorairolake commented Jul 22, 2023

What

packages/misskey-js配下のファイルなどの外部からインポートしたもの以外のソースコードに、REUSE Specificationのバージョン3.0で定義されている著作権 (SPDX-FileCopyrightText) とライセンス (SPDX-License-Identifier) についての情報を表すためのコメントを各ファイルの先頭に追加します。これらのタグはSPDXの仕様で定義されています12

なお、ライセンス関連の記述でAGPLの新しいバージョンが登場した場合にこれを選択することを認める記述が無かったのでAGPL-3.0-onlyとしましたが、もしこの認識が間違っている場合はAGPL-3.0-or-laterに修正しようと思います。

Resolves #11155

Why

Misskeyのソースコードをファイル単位など部分的に再利用する場合に、ファイルに適用されているライセンスの確認を容易にするため。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Footnotes

  1. https://spdx.github.io/spdx-spec/v2.3/using-SPDX-short-identifiers-in-source-files/

  2. https://spdx.github.io/spdx-spec/v2.3/file-tags/

@github-actions github-actions bot requested review from syuilo and tamaina July 22, 2023 09:33
@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/sw and PWA ServiceWorker and PWA related issue/PR packages/backend:test labels Jul 22, 2023
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #11348 (98accaf) into develop (b6790a4) will increase coverage by 0.81%.
The diff coverage is 88.70%.

@@             Coverage Diff             @@
##           develop   #11348      +/-   ##
===========================================
+ Coverage    77.66%   78.48%   +0.81%     
===========================================
  Files          918      920       +2     
  Lines        92636    96629    +3993     
  Branches      7748     7749       +1     
===========================================
+ Hits         71945    75836    +3891     
- Misses       20691    20793     +102     
Files Changed Coverage Δ
packages/backend/src/@types/hcaptcha.d.ts 0.00% <0.00%> (ø)
packages/backend/src/@types/http-signature.d.ts 0.00% <0.00%> (ø)
packages/backend/src/@types/os-utils.d.ts 0.00% <0.00%> (ø)
packages/backend/src/@types/package.json.d.ts 0.00% <0.00%> (ø)
packages/backend/src/@types/probe-image-size.d.ts 0.00% <0.00%> (ø)
packages/backend/src/@types/redis-lock.d.ts 0.00% <0.00%> (ø)
packages/backend/src/boot/index.ts 0.00% <0.00%> (ø)
packages/backend/src/boot/master.ts 0.00% <0.00%> (ø)
packages/backend/src/boot/worker.ts 0.00% <0.00%> (ø)
packages/backend/src/GlobalModule.ts 96.22% <100.00%> (+0.14%) ⬆️
... and 68 more

... and 840 files with indirect coverage changes

@sorairolake sorairolake marked this pull request as draft July 22, 2023 13:30
@sorairolake sorairolake force-pushed the chore/add-spdx-license-identifier branch 3 times, most recently from 99cc53d to 629779f Compare July 22, 2023 16:06
@sorairolake sorairolake marked this pull request as ready for review July 22, 2023 16:28
@sorairolake sorairolake marked this pull request as draft July 25, 2023 03:43
@sorairolake
Copy link
Contributor Author

後でhttps://github.com/fsfe/reuse-toolを使用して追加するように修正しようと思います。

@sorairolake sorairolake force-pushed the chore/add-spdx-license-identifier branch from 629779f to e874b0c Compare July 25, 2023 09:32
@sorairolake sorairolake changed the title chore: Add SPDX-License-Identifier chore: REUSE Specificationのバージョン3.0で定義されている著作権とライセンスについての情報を各ファイルに追加する Jul 25, 2023
@sorairolake sorairolake changed the title chore: REUSE Specificationのバージョン3.0で定義されている著作権とライセンスについての情報を各ファイルに追加する chore: 著作権とライセンスについての情報を各ファイルに追加する Jul 25, 2023
@sorairolake sorairolake marked this pull request as ready for review July 25, 2023 09:52
Add copyright and licensing information as defined in version 3.0 of
the REUSE Specification.
@sorairolake sorairolake force-pushed the chore/add-spdx-license-identifier branch from e874b0c to 6d115ba Compare July 25, 2023 11:41
@syuilo syuilo merged commit c2370a1 into misskey-dev:develop Jul 27, 2023
10 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 27, 2023

👍🏻

@sorairolake sorairolake deleted the chore/add-spdx-license-identifier branch July 28, 2023 05:52
EbiseLutica pushed a commit to shrimpia/misskey that referenced this pull request Jul 31, 2023
* chore: Add the SPDX information to each file

Add copyright and licensing information as defined in version 3.0 of
the REUSE Specification.

* tweak format

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
anatawa12 pushed a commit to anatawa12/misskey that referenced this pull request Aug 16, 2023
* chore: Add the SPDX information to each file

Add copyright and licensing information as defined in version 3.0 of
the REUSE Specification.

* tweak format

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/sw and PWA ServiceWorker and PWA related issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ソースコードにSPDX-License-Identifierを追加してほしい
2 participants