Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Remove redundant double quotes in page titles #11352

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Jul 22, 2023

What

不要な(と思われる)computed()を外してページのタイトルにあるダブルクォーテーションを削除します。

Why

Resolve #10240.

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 22, 2023
@github-actions github-actions bot requested review from syuilo and tamaina July 22, 2023 15:28
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #11352 (aba8f0a) into develop (b546d41) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11352      +/-   ##
===========================================
+ Coverage    77.69%   77.71%   +0.01%     
===========================================
  Files          918      920       +2     
  Lines        92621    92735     +114     
  Branches      7748     7749       +1     
===========================================
+ Hits         71966    72067     +101     
- Misses       20655    20668      +13     

see 9 files with indirect coverage changes

@acid-chicken acid-chicken merged commit dc452bf into misskey-dev:develop Jul 26, 2023
17 checks passed
@woxtu woxtu deleted the page-title branch July 27, 2023 16:46
@tai-cha tai-cha mentioned this pull request Jul 31, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ページのヘッダータイトルにダブルクォーテーションがある
2 participants