Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 動きのあるMFM無効時にレインボー文字が出ない問題を修正 #11361

Merged
merged 18 commits into from
Aug 21, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jul 23, 2023

What

  • 「動きのあるMFMを有効にする」が無効になっているときでも、テキストをレインボーにするようにフォールバックを追加
    image

Why

当該書式を使用している場合に、ノート作者が意図したように伝わらない可能性があるため

Additional info (optional)

現時点で「動きのあるMFMを有効にする」が有効になっているときでも、$[fg.color= ]などで文字色を変更しないとレインボーになりません。この問題も一緒に修復したほうが良いかも?

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 23, 2023
@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review July 23, 2023 07:13
@github-actions github-actions bot requested review from EbiseLutica and tamaina July 23, 2023 07:13
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #11361 (29be749) into develop (2939e81) will decrease coverage by 0.03%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #11361      +/-   ##
===========================================
- Coverage    78.66%   78.64%   -0.03%     
===========================================
  Files          923      922       -1     
  Lines        97492    97392     -100     
  Branches      7741     7741              
===========================================
- Hits         76695    76590     -105     
- Misses       20797    20802       +5     
Files Changed Coverage Δ
...src/components/global/MkMisskeyFlavoredMarkdown.ts 29.70% <0.00%> (-0.40%) ⬇️

... and 1 file with indirect coverage changes

@kakkokari-gtyih
Copy link
Contributor Author

CHANGELOG.md のコンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@syuilo syuilo merged commit 1f7a4b0 into misskey-dev:develop Aug 21, 2023
@syuilo
Copy link
Member

syuilo commented Aug 21, 2023

👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the mfm-rainbow-fallback branch August 21, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants