Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Use BullMQAdapter for bull-board #11367

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

hutchisr
Copy link
Contributor

What

Use BullMQAdapter instead of BullAdapter since misskey now uses bullmq instead of bull

Why

Fixes job dashboard to no longer give HTTP 500 errors when trying to perform actions

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #11367 (8082468) into develop (7097d55) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #11367      +/-   ##
===========================================
- Coverage    77.68%   77.67%   -0.02%     
===========================================
  Files          919      918       -1     
  Lines        92635    92576      -59     
  Branches      7749     7749              
===========================================
- Hits         71967    71908      -59     
  Misses       20668    20668              
Impacted Files Coverage Δ
...ages/backend/src/server/web/ClientServerService.ts 93.40% <100.00%> (ø)

... and 1 file with indirect coverage changes

@hutchisr hutchisr changed the title Use BullMQAdapter for bull-board fix:Use BullMQAdapter for bull-board Jul 24, 2023
@hutchisr hutchisr changed the title fix:Use BullMQAdapter for bull-board fix(backend): Use BullMQAdapter for bull-board Jul 24, 2023
@syuilo syuilo merged commit ac6a8ed into misskey-dev:develop Jul 25, 2023
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 25, 2023

👍

@hutchisr hutchisr deleted the bullmqadapter branch July 25, 2023 22:46
@tai-cha tai-cha mentioned this pull request Jul 31, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants