Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: モバイル表示のときページ下部がナビゲーションバーに隠れる問題を修正 #11370

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

ibuki2003
Copy link
Contributor

What

fix: #11317

ページ下部に挿入される余白の高さ --minBottomSpacing の値を、
media queryではなくJSで実際のnavbarの表示と連動させて設定するようにしました。

Why

navbarに隠れて操作できない領域が発生していたため。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 24, 2023
@github-actions github-actions bot requested review from syuilo and tamaina July 24, 2023 10:30
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #11370 (cefd825) into develop (8851e90) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11370      +/-   ##
===========================================
- Coverage    77.71%   77.66%   -0.05%     
===========================================
  Files          920      745     -175     
  Lines        92734    70976   -21758     
  Branches      7748     7251     -497     
===========================================
- Hits         72064    55125   -16939     
+ Misses       20670    15851    -4819     

see 176 files with indirect coverage changes

@syuilo syuilo merged commit 545b5ca into misskey-dev:develop Jul 25, 2023
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 25, 2023

👍🏻

@tai-cha tai-cha mentioned this pull request Jul 31, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

モバイル表示でページ下端にアクセスできなくなる
2 participants