Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): Use OFFSET instead of SKIP when using LIMIT #11379

Merged
merged 2 commits into from
Jul 25, 2023
Merged

fix(backend): Use OFFSET instead of SKIP when using LIMIT #11379

merged 2 commits into from
Jul 25, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Jul 25, 2023

Fix #11355

What

limitの場合はskipの代わりにoffsetを使う

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #11379 (77b6418) into develop (ac6a8ed) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11379      +/-   ##
===========================================
+ Coverage    77.67%   77.69%   +0.02%     
===========================================
  Files          918      173     -745     
  Lines        92575    21599   -70976     
  Branches      7748      498    -7250     
===========================================
- Hits         71905    16782   -55123     
+ Misses       20670     4817   -15853

see 745 files with indirect coverage changes

@tamaina
Copy link
Contributor Author

tamaina commented Jul 25, 2023

p1.a9z.devに適用

@syuilo syuilo merged commit c1a19ff into misskey-dev:develop Jul 25, 2023
16 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 25, 2023

🙏🙏🙏

@tai-cha tai-cha mentioned this pull request Jul 31, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acid-chicken acid-chicken acid-chicken approved these changes

Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
3 participants
@tamaina @syuilo @acid-chicken