Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(frontend): Reduce getting clientWidth in MkMediaImage #11386

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Jul 26, 2023

What

#11377 の続き

root.value.clientWidthが大変重たいため、スクロールコンテナごとにそれをキャッシュする

Why

パフォーマンス向上

Additional info (optional)

p1.a9z.devに適用

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #11386 (61d2bf0) into develop (545b5ca) will increase coverage by 0.03%.
Report is 2 commits behind head on develop.
The diff coverage is 58.62%.

@@             Coverage Diff             @@
##           develop   #11386      +/-   ##
===========================================
+ Coverage    77.68%   77.71%   +0.03%     
===========================================
  Files          918      920       +2     
  Lines        92601    92787     +186     
  Branches      7749     7749              
===========================================
+ Hits         71933    72107     +174     
- Misses       20668    20680      +12     
Files Changed Coverage Δ
packages/frontend/src/components/MkMediaList.vue 96.69% <58.62%> (-3.31%) ⬇️

... and 2 files with indirect coverage changes

@syuilo syuilo merged commit bc927b8 into misskey-dev:develop Jul 26, 2023
17 checks passed
@syuilo
Copy link
Member

syuilo commented Jul 26, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants