Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend, misskey-js): make block switch work #11429

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix(frontend, misskey-js): make block switch work #11429

merged 2 commits into from
Jul 31, 2023

Conversation

saschanaz
Copy link
Member

What

  1. admin/meta API callを復元
  2. metaやinstance情報がないとスイッチを非活性にする
  3. タイプの調整

Why

Fixes #11423

Additional info (optional)

@/accountのせいでテストは難しそうですのでタイプエラーだけ直しました

Checklist

  • Read the contribution guide
  • Test working in a local environment (N/A)
  • (If needed) Add story of storybook (N/A?)
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests (None)

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/misskey-js labels Jul 30, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #11429 (bc368d7) into develop (5096be0) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11429      +/-   ##
===========================================
+ Coverage    78.75%   78.76%   +0.01%     
===========================================
  Files          920      921       +1     
  Lines        97822    97886      +64     
  Branches      7837     7837              
===========================================
+ Hits         77037    77101      +64     
  Misses       20785    20785              

see 1 file with indirect coverage changes

@syuilo syuilo merged commit a52f63e into develop Jul 31, 2023
18 checks passed
@syuilo syuilo deleted the blockswitch branch July 31, 2023 03:22
@syuilo
Copy link
Member

syuilo commented Jul 31, 2023

🙏🏻

EbiseLutica pushed a commit to shrimpia/misskey that referenced this pull request Jul 31, 2023
* fix(frontend, misskey-js): make block switch work

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/instance-info/{info}でサーバーブロックができない
2 participants