Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 未読のお知らせの「わかった」をクリック・タップしてもその場で「わかった」が消えない問題を修正 #11433

Merged
merged 6 commits into from
Jul 31, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Jul 31, 2023

Fix #11432

What

MkPaginationのMap化で壊れたのを修正

Why

MkPaginationのMap化で壊れた

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@tamaina tamaina marked this pull request as ready for review July 31, 2023 04:25
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 31, 2023
@github-actions github-actions bot requested review from EbiseLutica and syuilo July 31, 2023 04:26
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #11433 (5c865bf) into develop (a52f63e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11433      +/-   ##
===========================================
+ Coverage    78.73%   78.74%   +0.01%     
===========================================
  Files          919      920       +1     
  Lines        97717    97781      +64     
  Branches      7839     7839              
===========================================
+ Hits         76937    77001      +64     
  Misses       20780    20780              

see 1 file with indirect coverage changes

@tamaina
Copy link
Contributor Author

tamaina commented Jul 31, 2023

いや普通に治ってない

@tamaina
Copy link
Contributor Author

tamaina commented Jul 31, 2023

いや治ってた

@tamaina tamaina merged commit bdf390e into develop Jul 31, 2023
@tamaina tamaina deleted the fix-ann branch July 31, 2023 05:13
EbiseLutica pushed a commit to shrimpia/misskey that referenced this pull request Jul 31, 2023
…y-dev#11433)

* fix(frontend): 未読のお知らせの「わかった」をクリック・タップしてもその場で「わかった」が消えない問題を修正

* remove comment

* clean up

* ✌️

* add CHANGELOG
anatawa12 pushed a commit to anatawa12/misskey that referenced this pull request Aug 16, 2023
…y-dev#11433)

* fix(frontend): 未読のお知らせの「わかった」をクリック・タップしてもその場で「わかった」が消えない問題を修正

* remove comment

* clean up

* ✌️

* add CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
1 participant