Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 押したリアクションのデザインを改善 #11434

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

EbiseLutica
Copy link
Contributor

What

resolve #11272

  • 自分が押したリアクションのデザインを改善し、絵文字の視認性をあげました

Why

元issueを参照

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #11434 (5d29d10) into develop (61c9b07) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #11434      +/-   ##
===========================================
+ Coverage    78.75%   78.85%   +0.09%     
===========================================
  Files          921      920       -1     
  Lines        97886    97779     -107     
  Branches      7834     7863      +29     
===========================================
+ Hits         77093    77099       +6     
+ Misses       20793    20680     -113     
Files Changed Coverage Δ
...tend/src/components/MkReactionsViewer.reaction.vue 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

@syuilo syuilo merged commit 4aed596 into develop Jul 31, 2023
18 checks passed
@syuilo syuilo deleted the better-ui-active-reaction branch July 31, 2023 08:38
@syuilo
Copy link
Member

syuilo commented Jul 31, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

自分が押したリアクションのデザイン改善案
2 participants