Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): ユーザーメニューでスイッチでユーザーリストに追加・削除できるように #11439

Merged
merged 6 commits into from
Aug 1, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Jul 31, 2023

Resolve #10484

What

  • メニューのスイッチの動作を改善
  • ユーザーメニューでスイッチでユーザーリストに追加・削除できるように

Additional info (optional)

p1.a9z.devに適用

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 31, 2023
@tamaina tamaina marked this pull request as ready for review July 31, 2023 08:42
@github-actions github-actions bot requested a review from acid-chicken July 31, 2023 08:45
@tamaina
Copy link
Contributor Author

tamaina commented Jul 31, 2023

残念ながらバグっている

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #11439 (869f4e4) into develop (4aed596) will decrease coverage by 0.06%.
Report is 1 commits behind head on develop.
The diff coverage is 71.56%.

@@             Coverage Diff             @@
##           develop   #11439      +/-   ##
===========================================
- Coverage    78.76%   78.71%   -0.06%     
===========================================
  Files          921      920       -1     
  Lines        97884    97839      -45     
  Branches      7838     7837       -1     
===========================================
- Hits         77102    77016      -86     
- Misses       20782    20823      +41     
Files Changed Coverage Δ
packages/frontend/src/pages/user/home.vue 92.76% <0.00%> (-0.15%) ⬇️
packages/frontend/src/scripts/get-user-menu.ts 5.58% <2.70%> (-0.45%) ⬇️
packages/frontend/src/scripts/get-note-menu.ts 5.14% <4.76%> (+0.07%) ⬆️
packages/frontend/src/components/MkMenu.vue 100.00% <100.00%> (ø)
packages/frontend/src/components/MkNote.vue 100.00% <100.00%> (ø)
...ckages/frontend/src/components/MkSwitch.button.vue 100.00% <100.00%> (ø)
packages/frontend/src/components/MkSwitch.vue 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@tamaina
Copy link
Contributor Author

tamaina commented Jul 31, 2023

なおした

@tamaina
Copy link
Contributor Author

tamaina commented Jul 31, 2023

スクショ

image

@tamaina tamaina mentioned this pull request Jul 31, 2023
5 tasks
@syuilo syuilo merged commit 8a72a05 into misskey-dev:develop Aug 1, 2023
@syuilo
Copy link
Member

syuilo commented Aug 1, 2023

👍

@tamaina
Copy link
Contributor Author

tamaina commented Aug 1, 2023

あれ、タッチデバイスで動かない…?

@tamaina
Copy link
Contributor Author

tamaina commented Aug 1, 2023

いやそんなことないな

ちょっと動作が不安定な気がするけどどうしてそうなるのかわからない
(Promiseが早期にresolveされてしまってunwatchされているようには見える

@tamaina
Copy link
Contributor Author

tamaina commented Aug 1, 2023

ドロワだと子メニューを開くとcloseしちゃうのか

@syuilo
Copy link
Member

syuilo commented Aug 1, 2023

ちゃんと(?)やるならメニュー流用するのではなくて専用のコンポーネントこしらえた方が良さそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ユーザーをユーザーリストから削除しやすくしてほしい
2 participants