Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend/ApNoteService): try retrieving again when failed by duplication #11472

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

saschanaz
Copy link
Member

What

insert失敗したらDBにデータがあるのかもう一度確認

Why

Fixes #11471

Additional info (optional)

もっといい方法を考えてみましたが、わからなかったのでこうしました。なんかDBに対応するResolver.historyに似たようなものが欲しいかも

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook (N/A)
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Aug 6, 2023
@github-actions github-actions bot requested review from syuilo and tamaina August 6, 2023 00:28
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #11472 (16a2761) into develop (b439067) will increase coverage by 0.00%.
The diff coverage is 81.25%.

@@           Coverage Diff            @@
##           develop   #11472   +/-   ##
========================================
  Coverage    78.61%   78.62%           
========================================
  Files          920      920           
  Lines        97388    97400   +12     
  Branches      7695     7703    +8     
========================================
+ Hits         76563    76578   +15     
+ Misses       20825    20822    -3     
Files Changed Coverage Δ
...ckend/src/core/activitypub/models/ApNoteService.ts 65.50% <81.25%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@syuilo
Copy link
Member

syuilo commented Aug 8, 2023

👍👍

@syuilo syuilo merged commit ec229db into develop Aug 8, 2023
@syuilo syuilo deleted the feature-note-fetch-test branch August 8, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ノートを照会してfeatured noteだったら照会失敗する
2 participants