Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Misskeyプラグインをインストールする際のAiScriptバージョンのチェックが0.14.0以降に対応していない問題を修正 #11729

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

Sayamame-beans
Copy link
Member

What

if (lastVersion != null && compareVersions(version, lastVersion) === 1) {
で利用されているcompareVersionsを使って、AiScript0.12.0以降の全てのバージョンに対応させます。
Close #11420

Why

  • 0.14.0以降のバージョン表記がある場合にプラグインがインストール出来ないため。
  • 0.12.0.13.が含まれているかどうかという判別方法では、条件が無限に増えていってしまうため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #11729 (ed12aae) into develop (792622a) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #11729      +/-   ##
===========================================
- Coverage    78.83%   78.71%   -0.13%     
===========================================
  Files          922      748     -174     
  Lines        97709    74966   -22743     
  Branches      7767     7221     -546     
===========================================
- Hits         77032    59010   -18022     
+ Misses       20677    15956    -4721     

see 190 files with indirect coverage changes

@Sayamame-beans
Copy link
Member Author

スクリプト側の表記がsemver表記でない場合にエラーが発生する可能性があるため調査・修正中です

@Sayamame-beans
Copy link
Member Author

修正を加えました。

@syuilo syuilo merged commit ba16abb into misskey-dev:develop Aug 18, 2023
@syuilo
Copy link
Member

syuilo commented Aug 18, 2023

👍🏻

@Sayamame-beans Sayamame-beans deleted the issue-11420 branch August 18, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MisskeyプラグインのバージョンチェックがAiScript 0.14.0以降に対応していない
3 participants