Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refine 2fa #11766

Merged
merged 6 commits into from
Aug 28, 2023
Merged

feat: Refine 2fa #11766

merged 6 commits into from
Aug 28, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Aug 27, 2023

What

Resolve #3566

それと設定をウィザード形式にした
Animation

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/backend:test labels Aug 27, 2023
@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #11766 (81304ed) into develop (39d9172) will decrease coverage by 0.14%.
The diff coverage is 80.76%.

@@             Coverage Diff             @@
##           develop   #11766      +/-   ##
===========================================
- Coverage    78.78%   78.64%   -0.14%     
===========================================
  Files          924      923       -1     
  Lines        97580    97501      -79     
  Branches      7776     7750      -26     
===========================================
- Hits         76878    76683     -195     
- Misses       20702    20818     +116     
Files Changed Coverage Δ
...ackages/backend/src/server/api/SigninApiService.ts 79.45% <28.57%> (-1.25%) ⬇️
...ges/backend/src/core/entities/UserEntityService.ts 95.23% <100.00%> (+<0.01%) ⬆️
...ackages/backend/src/models/entities/UserProfile.ts 100.00% <100.00%> (ø)
packages/backend/src/models/json-schema/user.ts 100.00% <100.00%> (ø)
...ges/backend/src/server/api/endpoints/i/2fa/done.ts 94.73% <100.00%> (+0.53%) ⬆️
...ckend/src/server/api/endpoints/i/2fa/unregister.ts 96.72% <100.00%> (+0.05%) ⬆️

... and 17 files with indirect coverage changes

@u1-liquid
Copy link
Sponsor Contributor

AGPLに基づいて MisskeyIO#121 のソースコードを持ってきたのであれば元のPRなどの出典についてコミットメッセージなどに書いて置くべきだと思う

@syuilo
Copy link
Member Author

syuilo commented Aug 28, 2023

squash時に書くか

@syuilo syuilo marked this pull request as ready for review August 28, 2023 07:33
@github-actions github-actions bot requested a review from tamaina August 28, 2023 07:33
@syuilo syuilo merged commit 257c4fc into develop Aug 28, 2023
17 checks passed
@syuilo syuilo deleted the refine-2fa branch August 28, 2023 09:25
@u1-liquid
Copy link
Sponsor Contributor

squash時に書くか

書かれてないかも

@syuilo
Copy link
Member Author

syuilo commented Aug 28, 2023

おあー忘れてた

@syuilo
Copy link
Member Author

syuilo commented Aug 28, 2023

CHANGELOGに書いた

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2段階認証のバックアップコード
2 participants