Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): センシティブなメディアを目立たせる設定を追加 #11851

Merged
merged 17 commits into from
Sep 22, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 19, 2023

What

データセーバー有効時における誤タップ防止のために、センシティブなメディアに黄色枠線を付けられる設定を追加(デフォルトオフ

あとBlurhash時の画像の明るさを若干明るくしました

image

image

image

動画も同様

image

Why

Resolve #11442

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +15.03% 🎉

Comparison is base (c836157) 78.90% compared to head (f6b20b8) 93.93%.

❗ Current head f6b20b8 differs from pull request most recent head c1428b0. Consider uploading reports for the commit c1428b0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #11851       +/-   ##
============================================
+ Coverage    78.90%   93.93%   +15.03%     
============================================
  Files          930        2      -928     
  Lines        98292      462    -97830     
  Branches      7817       59     -7758     
============================================
- Hits         77555      434    -77121     
+ Misses       20737       28    -20709     

see 928 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Sep 20, 2023

非センシティブなメディアの表示まで変わるのはアレかも

@syuilo
Copy link
Member

syuilo commented Sep 20, 2023

box-shadowとか使えないかしら

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 20, 2023

box-shadowとか使えないかしら

box-shadowは最下部にかかるので画像とBlurhashの下に隠れてしまいました

after疑似要素も試したんですが、コンポーネント外からborder-radiusをかけられると対応できなかったのでやむを得ずこういう実装にしてみました

@kakkokari-gtyih

This comment was marked as off-topic.

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 20, 2023

Box-shadowで外向きに縁取りをつけるか(フォーカスが当たった場合と混同しやすそう)

kakkokari-gtyih and others added 2 commits September 20, 2023 13:35
@kakkokari-gtyih
Copy link
Contributor Author

なんとかなった(かも)

@kakkokari-gtyih
Copy link
Contributor Author

image

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 22, 2023

✔(テストはバックエンドで落ちてるのでPRと関係なさそう)

@syuilo syuilo merged commit 7dc9fe4 into misskey-dev:develop Sep 22, 2023
8 of 9 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 22, 2023

👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the sensitive-dsv branch September 22, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

データセーバー(非センシティブ)とセンシティブの区別がつくようにする
2 participants