Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mk:apiで外部サーバーとの接続を禁止 #11883

Merged
merged 5 commits into from
Sep 24, 2023

Conversation

FineArchs
Copy link
Contributor

@FineArchs FineArchs commented Sep 24, 2023

What

Mk:apiの第1引数がurlだった時にエラーを出すことで外部との通信を禁止します。

Why

#11882

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 24, 2023
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d05563c) 78.79% compared to head (8062fc2) 78.79%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #11883   +/-   ##
========================================
  Coverage    78.79%   78.79%           
========================================
  Files          928      928           
  Lines        98541    98541           
  Branches      7845     7848    +3     
========================================
  Hits         77648    77648           
  Misses       20893    20893           

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

FineArchs and others added 2 commits September 24, 2023 14:15
@syuilo syuilo merged commit 30b2312 into misskey-dev:develop Sep 24, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 24, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants