Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backend): Use request.routeOptions.url instead of request.routerPath to supress FSTDEP017 #11935

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

AsPulse
Copy link
Contributor

@AsPulse AsPulse commented Sep 30, 2023

What

Why

  • issueにもある通り、request.routerPathはFastifyの次のメジャーアップデートで削除される予定の非推奨プロパティです。
  • 早急に変える必要は認められないといえばそうなのですが、
    このせいで警告FSTDEP017がリクエストごとにログに出てきて少し邪魔です……

Checklist

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (09dfb9b) 78.95% compared to head (008da6c) 78.92%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11935      +/-   ##
===========================================
- Coverage    78.95%   78.92%   -0.03%     
===========================================
  Files          929      928       -1     
  Lines        99194    99089     -105     
  Branches      7889     7886       -3     
===========================================
- Hits         78318    78208     -110     
- Misses       20876    20881       +5     
Files Coverage Δ
...ages/backend/src/server/web/ClientServerService.ts 88.25% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AsPulse AsPulse marked this pull request as ready for review September 30, 2023 05:20
@syuilo syuilo merged commit 6840434 into misskey-dev:develop Sep 30, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 30, 2023

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request.routerPathが非推奨になった影響で、警告 [FSTDEP017] が表示される (refactor)
2 participants