Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: 編集したノートの履歴を確認できるように #11938

Closed

Conversation

GrapeApple0
Copy link
Contributor

@GrapeApple0 GrapeApple0 commented Sep 30, 2023

What

編集したノートの履歴をノートの詳細ページに表示されるようにしました。
screenshot 866

Why

編集前のノートが見れなくなるため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5fd0cb3) 79.22% compared to head (86e6538) 79.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11938      +/-   ##
===========================================
- Coverage    79.22%   79.21%   -0.01%     
===========================================
  Files          931      930       -1     
  Lines        99481    99447      -34     
  Branches      8003     8005       +2     
===========================================
- Hits         78809    78773      -36     
- Misses       20672    20674       +2     
Files Coverage Δ
...ges/backend/src/core/entities/NoteEntityService.ts 86.62% <100.00%> (+0.05%) ⬆️
packages/backend/src/models/Note.ts 100.00% <100.00%> (ø)
packages/backend/src/models/json-schema/note.ts 100.00% <100.00%> (ø)
...s/backend/src/server/api/endpoints/notes/update.ts 75.82% <0.00%> (-1.71%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GrapeApple0 GrapeApple0 changed the title 編集したノートの履歴を確認できるように enhance: 編集したノートの履歴を確認できるように Oct 1, 2023
@noridev
Copy link
Contributor

noridev commented Oct 2, 2023

こんにちは、小さな意見ですが、各ノートを編集した時間も別々に表示されたらどうかと思い、コメントしてみます。

@syuilo
Copy link
Member

syuilo commented Oct 4, 2023

履歴見れる必要ありそう?

@syuilo
Copy link
Member

syuilo commented Oct 4, 2023

機能自体キャンセルする可能性が高まってきたので作業はストップしていただけると🙏

@syuilo
Copy link
Member

syuilo commented Oct 4, 2023

一旦ノート編集機能は撤回されました 🙏🏻

@syuilo syuilo closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants