Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve tl performance #11946

Merged
merged 51 commits into from
Oct 3, 2023
Merged

feat: improve tl performance #11946

merged 51 commits into from
Oct 3, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Oct 1, 2023

What

Why

Resolve #9325

Additional info (optional)

  • ソフトワードミュートとハードワードミュートの統合
  • チャンネルフォロー
  • users/notesも
  • stl
  • trim stl
  • gtl
  • withReplies対応
    • タイムラインのオプションとしては廃止
    • フォローするユーザーごとに「返信をタイムラインに表示」するかどうか設定できるようにする
    • リスインするユーザーごとに「返信をタイムラインに表示」するかどうか設定できるようにする
  • limit未満の場合の対応
  • redis分けられるようにする
  • test
    • タイムラインにリノートミュートしているユーザーの引用が含まれる
    • ファイルタイプ指定
  • テスト追加

nice to have

  • フォローキャッシュ
    • キャッシュ更新処理
  • ミュート考慮処理はポスグレに問い合わせる前の段階でやる
  • isHybernate
    • 投稿ごとに10%程度の確率で、以下を行う
      • フォロワーを1000件程度サンプリングし、lastUsedAtが1ヶ月以上前であればisHyvernateをtrueにする/tlクリア
    • ユーザーがログインしてlastUsedAt更新時、自分がhybernateされていたらfalseにする

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 1, 2023
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5ee93dc) 78.91% compared to head (77498f8) 78.67%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11946      +/-   ##
===========================================
- Coverage    78.91%   78.67%   -0.24%     
===========================================
  Files          928      176     -752     
  Lines        99103    23148   -75955     
  Branches      7882      511    -7371     
===========================================
- Hits         78205    18212   -59993     
+ Misses       20898     4936   -15962     
Files Coverage Δ
packages/frontend/src/components/MkNote.vue 100.00% <100.00%> (ø)
packages/frontend/src/components/MkNoteSub.vue 100.00% <100.00%> (ø)
packages/frontend/src/pages/user/home.vue 90.92% <100.00%> (ø)
packages/frontend/src/scripts/get-user-menu.ts 5.08% <0.00%> (-0.19%) ⬇️

... and 750 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 1, 2023
@syuilo
Copy link
Member Author

syuilo commented Oct 1, 2023

60%くらい終わった

@syuilo
Copy link
Member Author

syuilo commented Oct 2, 2023

70%くらい終わった

@syuilo
Copy link
Member Author

syuilo commented Oct 2, 2023

withReplies周りをまあまあ改修する必要が出てきた

@syuilo
Copy link
Member Author

syuilo commented Oct 2, 2023

「リノートをミュート」みたいにFollowingの属性としてTLにその人の他の人への返信も含めるかどうかを持たせるようにする

@syuilo
Copy link
Member Author

syuilo commented Oct 2, 2023

UserListJoiningも同様とする

@syuilo
Copy link
Member Author

syuilo commented Oct 2, 2023

力尽きそう

@syuilo
Copy link
Member Author

syuilo commented Oct 3, 2023

80%くらい終わった

@syuilo syuilo marked this pull request as ready for review October 3, 2023 08:10
@syuilo
Copy link
Member Author

syuilo commented Oct 3, 2023

マージするか

@syuilo syuilo merged commit 6277a55 into develop Oct 3, 2023
16 checks passed
GrapeApple0 added a commit to GrapeApple0/misskey that referenced this pull request Oct 6, 2023
anatawa12 added a commit to anatawa12/misskey that referenced this pull request Oct 10, 2023
Suzulu-activity pushed a commit to 9ineverse-dev/Type-9ine-legacy that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLをPush型にする
1 participant