Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use pnpm@8.8.0 on DevContainer #11975

Merged

Conversation

Nanashia
Copy link
Contributor

@Nanashia Nanashia commented Oct 6, 2023

What

DevContainer環境で使うpnpmのバージョンをlatestから8.8.0に固定する

Why

DevContainerではデフォルトのpnpmは(なぜか)7.28.0がインストールされるが、このバージョンではpnpm installが正しく動かない。
おそらく原因はpnpmのバグ pnpm/pnpm#6424 で 8.3.1 で修正されている。
8.8.0を使えば問題なくpnpm iできる。

node ➜ /workspace (develop) $ pnpm install --frozen-lockfile
Scope: all 5 workspace projects
Lockfile is up to date, resolution step is skipped
 WARN  GET https://codeload.github.com/misskey-dev/storybook-addon-misskey-theme/tar.gz/cf583db098365b2ccc81a82f63ca9c93bc32b640 error (ERR_INVALID_THIS). Will retry in 10 seconds. 2 retries left.
Packages: +1
+
 WARN  GET https://codeload.github.com/misskey-dev/storybook-addon-misskey-theme/tar.gz/cf583db098365b2ccc81a82f63ca9c93bc32b640 error (ERR_INVALID_THIS). Will retry in 1 minute. 1 retries left.
 ERR_INVALID_THIS  Value of "this" must be of type URLSearchParams

pnpm [ERR_INVALID_THIS]: Value of "this" must be of type URLSearchParams
    at new NodeError (node:internal/errors:405:5)
    at Proxy.getAll (node:internal/url:527:13)
    at Proxy.<anonymous> (/usr/local/share/npm-global/lib/node_modules/pnpm/dist/pnpm.cjs:59406:55)
    at /usr/local/share/npm-global/lib/node_modules/pnpm/dist/pnpm.cjs:59468:31
    at Array.reduce (<anonymous>)
    at Proxy.raw (/usr/local/share/npm-global/lib/node_modules/pnpm/dist/pnpm.cjs:59467:33)
    at new Headers (/usr/local/share/npm-global/lib/node_modules/pnpm/dist/pnpm.cjs:59352:28)
    at getNodeRequestOptions (/usr/local/share/npm-global/lib/node_modules/pnpm/dist/pnpm.cjs:59701:23)
    at /usr/local/share/npm-global/lib/node_modules/pnpm/dist/pnpm.cjs:59758:25
    at new Promise (<anonymous>)
Progress: resolved 1, reused 0, downloaded 0, added 0
node ➜ /workspace (develop) $ 

また、 package.jsonには ac19b05"packageManager": "pnpm@8.8.0" が明記されているので一致させておいたほうがよい。

Additional info (optional)

  • DevContainerをRebuildしてpnpmのバージョンが上がっていること。
  • pnpm startしてdevサーバーが立ち上がること

Before

node ➜ /workspace (develop) $ pnpm -v
7.28.0

After

node ➜ /workspace (chore/set-pnpm-version-on-devcontainer) $ pnpm -v
8.8.0

環境:

  • Windows 10 Pro 22H2
  • Docker Desktop 4.24.1
  • VSCode 1.83.0

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e4dcab8) 79.27% compared to head (2cb6c60) 78.86%.
Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11975      +/-   ##
===========================================
- Coverage    79.27%   78.86%   -0.41%     
===========================================
  Files          929      178     -751     
  Lines        99373    23279   -76094     
  Branches      8042      510    -7532     
===========================================
- Hits         78776    18359   -60417     
+ Misses       20597     4920   -15677     

see 754 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 691fe71 into misskey-dev:develop Oct 6, 2023
14 of 15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 6, 2023

👍🏻

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants