Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) メールアドレス認証失敗時にメッセージが出るようにする #11986

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Oct 8, 2023

What

上記の通り

Why

Fix #11972
本当はもうちょっとちゃんとした画面を設計する必要があるが、何も出ない状況だけでも早急に解決する必要があるので、暫定措置としてとりあえずメッセージは出力できるようにした

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (308745f) 79.24% compared to head (3e13355) 79.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11986      +/-   ##
===========================================
- Coverage    79.24%   79.22%   -0.03%     
===========================================
  Files          933      932       -1     
  Lines        99840    99776      -64     
  Branches      8070     8064       -6     
===========================================
- Hits         79122    79050      -72     
- Misses       20718    20726       +8     
Files Coverage Δ
packages/backend/src/server/ServerService.ts 50.19% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit f37a3ef into misskey-dev:develop Oct 8, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 8, 2023

👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the email-verify-hotfix branch October 8, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
2 participants