Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set http header for CORS in nodeinfo page #11988

Merged
merged 4 commits into from
Oct 8, 2023

Conversation

Srgr0
Copy link
Collaborator

@Srgr0 Srgr0 commented Oct 8, 2023

What

CORS用のヘッダーを設定する。
設定内容はWellKnownServerService.tsと同じにした。

Why

fix #11987

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8e0fb23) 93.93% compared to head (2df4d17) 78.71%.
Report is 1 commits behind head on develop.

❗ Current head 2df4d17 differs from pull request most recent head 030921b. Consider uploading reports for the commit 030921b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #11988       +/-   ##
============================================
- Coverage    93.93%   78.71%   -15.23%     
============================================
  Files            2      176      +174     
  Lines          462    23118    +22656     
  Branches        59      510      +451     
============================================
+ Hits           434    18198    +17764     
- Misses          28     4920     +4892     

see 174 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit bb9f04d into misskey-dev:develop Oct 8, 2023
9 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 8, 2023

👍🏻

@Srgr0 Srgr0 deleted the set-cors-nodeinfo branch October 8, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodeinfoにおいてCORSが設定されていない
2 participants