Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat:「ファイルの詳細」ページを追加 #11995

Merged
merged 12 commits into from
Oct 10, 2023
Merged

Feat:「ファイルの詳細」ページを追加 #11995

merged 12 commits into from
Oct 10, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Oct 9, 2023 •
edited
Loading

What

  • 「ファイルの詳細」ページを追加
    • ドライブでファイルをクリックしたら、メニューが出るのではなくこのページに飛ぶ
      • メニューは左クリックに残してある
    • ファイルの詳細情報を閲覧・修正できる
    • ファイルのプレビューが見れる
      • 画像の拡大・動画の再生が可能に
    • そのファイルが添付されたノートの一覧を確認できる
  • API drive/files/attached-notes がページネーションに対応

image

image

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@kakkokari-gtyih kakkokari-gtyih changed the title 「ファイルの詳細」ページを追加 Feat:「ファイルの詳細」ページを追加 Oct 9, 2023
@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Oct 9, 2023
@kakkokari-gtyih
Copy link
Contributor Author

ファイルの詳細ページの全体像

image

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4eb9e50) 79.09% compared to head (6696e7f) 79.24%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #11995      +/-   ##
===========================================
+ Coverage    79.09%   79.24%   +0.15%     
===========================================
  Files          174      176       +2     
  Lines        22715    22880     +165     
  Branches       485      485              
===========================================
+ Hits         17966    18131     +165     
  Misses        4749     4749
Files Coverage Δ
packages/frontend/src/router.ts 99.26% <100.00%> (+<0.01%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft October 9, 2023 10:14
@kakkokari-gtyih
Copy link
Contributor Author

APIエンドポイントはすでにあったので修正

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review October 9, 2023 10:31
@kakkokari-gtyih
Copy link
Contributor Author

SQL系のセキュリティー大丈夫かわからないのでわかる方みてもらえると

@syuilo syuilo self-requested a review October 9, 2023 10:36
@syuilo
Copy link
Member

syuilo commented Oct 9, 2023

このページが自分のみ見れるというinfoをどこかに表示しておくとよいかもしれない

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Oct 9, 2023 •
edited
Loading

image

image

@syuilo syuilo merged commit af1087a into misskey-dev:develop Oct 10, 2023
14 of 15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 10, 2023

👍🏻👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the drive-file-preview branch October 10, 2023 02:22
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Oct 12, 2023
@kakkokari-gtyih @kanarikanaru
Feat:「ファイルの詳細」ページを追加 (misskey-dev#11995)
ba94acf 
* (add) ファイルビューア

* Update Changelog

* 既存のAPIを利用

* run api extratctor

* Change i18n

* (add) ページに関する説明を追加

* Update CHANGELOG

* (fix) design, classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo syuilo left review comments

Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
2 participants
@kakkokari-gtyih @syuilo