Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 投稿フォームでのユーザー変更がプレビューに反映されるように修正 #12022

Merged
merged 4 commits into from
Oct 22, 2023

Conversation

zyoshoka
Copy link
Contributor

What

投稿フォームでユーザーを変更したときにプレビューに反映されるようにしました

Why

Fix: #11899

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2697826) 79.36% compared to head (7d0af31) 79.37%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12022      +/-   ##
===========================================
+ Coverage    79.36%   79.37%   +0.01%     
===========================================
  Files          939      941       +2     
  Lines       100332   100503     +171     
  Branches      8183     8175       -8     
===========================================
+ Hits         79625    79779     +154     
- Misses       20707    20724      +17     
Files Coverage Δ
packages/frontend/src/components/MkNotePreview.vue 100.00% <100.00%> (ø)
packages/frontend/src/components/MkPostForm.vue 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 983b1e6 into misskey-dev:develop Oct 22, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 22, 2023

🙏

tai-cha pushed a commit to nadesskey/nadesskey that referenced this pull request Oct 25, 2023
* fix(frontend): 投稿フォームでのユーザー変更がプレビューに反映されるように修正

* Update CHANGELOG.md
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 2, 2023
* fix(frontend): 投稿フォームでのユーザー変更がプレビューに反映されるように修正

* Update CHANGELOG.md
@zyoshoka zyoshoka deleted the preview-user-change-in-post-form branch May 15, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

投稿フォームでユーザーを変更してもプレビューに反映されない
2 participants