Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 引用リノート時の入力欄にフォーカスが当たらずすぐに入力が出来ないのを修正 #12267

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

samunohito
Copy link
Member

ポップアップの表示後、MkNoteとMkNoteDetailedでそれぞれが持つfocusメソッドを呼び出していたのをやめた

What

#12266 の対応です。
この対応により、引用リノート時の入力欄にフォーカスが当たるようになります。

Why

引用リノート時にすぐ入力を開始できない状態になっており、地味に不便

Additional info (optional)

ローカルで実際に動かして確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md ※次リリースの枠が無かったので、いったん書き足さずに置いてあります
  • (If possible) Add tests

ポップアップの表示後、MkNoteとMkNoteDetailedでそれぞれが持つfocusメソッドを呼び出していたのをやめた
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 6, 2023
@syuilo syuilo merged commit 828749b into misskey-dev:develop Nov 6, 2023
12 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 6, 2023

👍🏻

Copy link
Contributor

github-actions bot commented Nov 6, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 9, 2023
ポップアップの表示後、MkNoteとMkNoteDetailedでそれぞれが持つfocusメソッドを呼び出していたのをやめた

Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com>
tai-cha pushed a commit to nadesskey/nadesskey that referenced this pull request Nov 20, 2023
ポップアップの表示後、MkNoteとMkNoteDetailedでそれぞれが持つfocusメソッドを呼び出していたのをやめた

Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com>
@samunohito samunohito deleted the fix/12266_unwanted_focus branch January 11, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants