Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ページ一覧ページの表示がモバイル環境において崩れているのを修正 #12354

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

lynlynlynx
Copy link
Contributor

@lynlynlynx lynlynlynx commented Nov 17, 2023

What

ページ一覧ページ (/pages やユーザープロフィールのページタブ)が、モバイル環境で崩れているのを修正しました。

Why

いろいろ破壊されていたので。

比較

before after
image image

Additional info (optional)

そもそも一般的な狭めのデッキのカラム幅ではサムネイル高さが低くなるようにならないし、デバイス幅で場合分けしてモバイル環境だけサムネイル高さを低くfixする必要があるのか謎かもしれない気はする。
これはまあissueで話した方がいいので消しておきます。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f007890) 78.80% compared to head (c61a931) 78.81%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12354      +/-   ##
===========================================
+ Coverage    78.80%   78.81%   +0.01%     
===========================================
  Files          946      947       +1     
  Lines       102270   102334      +64     
  Branches      8262     8262              
===========================================
+ Hits         80594    80658      +64     
  Misses       21676    21676              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 17, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit cbebe85 into misskey-dev:develop Nov 19, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 19, 2023

🙏🙏🙏

@lynlynlynx lynlynlynx deleted the poka-fixlistofpages branch December 23, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants