Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 「設定のバックアップ」に一部の設定項目が含まれていない問題を修正 #12366

Merged
merged 4 commits into from
Nov 19, 2023

Conversation

hideki0403
Copy link
Contributor

What

クライアントの「設定のバックアップ」で作成できるバックアップに不足している設定項目を追加しました。
設定画面から変更できる項目のみ追加しています。

Why

現在の「設定のバックアップ」では通知の表示位置やサウンド設定を始めとする一部の項目がバックアップ出来ておらず、該当項目を手動で設定する必要があり不便なため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f7d10b) 78.74% compared to head (92b4823) 78.74%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12366      +/-   ##
===========================================
- Coverage    78.74%   78.74%   -0.01%     
===========================================
  Files          948      948              
  Lines       102479   102479              
  Branches      8272     8271       -1     
===========================================
- Hits         80701    80699       -2     
- Misses       21778    21780       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit 02b0adf into misskey-dev:develop Nov 19, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 19, 2023

🙏

@hideki0403 hideki0403 deleted the fix-preferences-backup branch November 19, 2023 05:02
anatawa12 pushed a commit to anatawa12/misskey that referenced this pull request Nov 26, 2023
* fix: 一部の設定項目がバックアップに含まれていなかったのを修正

* update: CHANGELOG.md

* remove: バックアップ不要な項目を削除
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants