Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

サウンド再生方法の変更に追従できていなかった所を修正 #12368

Merged

Conversation

samunohito
Copy link
Member

What

#12367 の対応です。
上記不具合が解消されます。

Why

ジョブキューに異常があったときに音が鳴らなくなっているため

Additional info (optional)

waitingが1以上なダミーのオブジェクトを関数に流し込んで発音を確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 19, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0de863) 78.71% compared to head (312d98e) 78.75%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12368      +/-   ##
===========================================
+ Coverage    78.71%   78.75%   +0.03%     
===========================================
  Files          947      949       +2     
  Lines       102411   102581     +170     
  Branches      8273     8273              
===========================================
+ Hits         80613    80783     +170     
  Misses       21798    21798              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 19, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo
Copy link
Member

syuilo commented Nov 21, 2023

オーディオの再生方法に関する具体的な知識を scripts/sound.ts から漏らしたくないけど後でやればいいか

@syuilo syuilo merged commit 4b13179 into misskey-dev:develop Nov 21, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 21, 2023

🙏

anatawa12 pushed a commit to anatawa12/misskey that referenced this pull request Nov 27, 2023
Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com>
@samunohito samunohito deleted the fix/widget-job-queue-jammed-sound branch January 11, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants