Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backendのプロジェクトで単体で start できないのを修正 #12371

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

fruitriin
Copy link
Contributor

What

backendのプロジェクトで pnpm start してもエントリファイルが正しくないため起動しない

Why

今後frontとbackendの分離を行うならその布石として

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 19, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02b0adf) 78.73% compared to head (638d003) 78.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12371      +/-   ##
===========================================
+ Coverage    78.73%   78.85%   +0.11%     
===========================================
  Files          948      949       +1     
  Lines       102517   102581      +64     
  Branches      8273     8303      +30     
===========================================
+ Hits         80719    80890     +171     
+ Misses       21798    21691     -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit e0de863 into misskey-dev:develop Nov 19, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 19, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants