広告掲載ページにてfilterをわかりやすく

[nenohi]

What

・広告掲載ページのfilterをわかりやすく

・広告掲載ページの削除や追加時に画像が変わらない問題の解決

Why

・スイッチだと分かりづらいというのと、バグ対応

Additional info (optional)

・ローカルにてテスト済み

Checklist

• Read the contribution guide
• Test working in a local environment
• (If needed) Add story of storybook
• (If needed) Update CHANGELOG.md
• (If possible) Add tests

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0de863) 78.71% compared to head (d88b9b7) 78.73%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #12385      +/-   ##
===========================================
+ Coverage    78.71%   78.73%   +0.01%     
===========================================
  Files          947      177     -770     
  Lines       102411    23440   -78971     
  Branches      8273      495    -7778     
===========================================
- Hits         80613    18455   -62158     
+ Misses       21798     4985   -16813     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

このPRによるapi.jsonの差分

差分はこちら

--- base
+++ head
@@ -1734,7 +1734,8 @@
                   },
                   "publishing": {
                     "type": "boolean",
-                    "default": false
+                    "default": null,
+                    "nullable": true
                   }
                 },
                 "required": []

Get diff files from Workflow Page

[syuilo]

🙏

[u1-liquid]

これを持っていくといいとされています
MisskeyIO@080fb93