サーバ起動時にアンテナが非アクティブだった場合、アクティブ化しても再起動するまで反映されない #12391
Merged
+28
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12391 +/- ##
===========================================
- Coverage 78.77% 78.63% -0.15%
===========================================
Files 947 176 -771
Lines 102729 23334 -79395
Branches 8274 495 -7779
===========================================
- Hits 80929 18349 -62580
+ Misses 21800 4985 -16815 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら |
syuilo
reviewed
Nov 21, 2023
| }); | ||
| if (!antenna.isActive) { | ||
| antenna.isActive = true; | ||
| antenna.lastUsedAt = new Date(); |
There was a problem hiding this comment.
isActiveだった場合lastUsedAtが更新されないけど大丈夫そうかしら
There was a problem hiding this comment.
大丈夫じゃないですね…
修正しました:pray:
There was a problem hiding this comment.
読み込みのたびにlastUsedAtが更新されるのも無駄感あるからそのうちなんとかしたいわね
|
🙏 |
anatawa12
pushed a commit
to anatawa12/misskey
that referenced
this pull request
Nov 26, 2023
* サーバ起動時にアンテナが非アクティブだった場合、アクティブ化しても再起動するまで反映されない * Fix CHANGELOG.md * lastUsedAtの更新に不備が出るので修正 --------- Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#12303 の対応です。
この対応により、アンテナの再アクティブ化がすぐに反映されて再びユーザのアンテナTLに配信されるようになります。
deactivateAntennaThreshold（デフォだと一週間）以上再起動していないサーバではこの現象が起こりやすくなります。Why
サーバが再起動するまで再アクティブ化されたアンテナの状態が反映されないのは不便
Additional info (optional)
以下手順で確認
Checklist