Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend/MkMediaVideo): loop and autoplay silent videos #12392

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

acid-chicken
Copy link
Member

What

無音の動画っぽい場合はループして自動再生するように

Why

Resolve #3969

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@acid-chicken acid-chicken added the packages/frontend Client side specific issue/PR label Nov 21, 2023
@acid-chicken acid-chicken self-assigned this Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e0de863) 78.71% compared to head (b20c24f) 78.70%.

Files Patch % Lines
packages/frontend/src/scripts/media-has-audio.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12392      +/-   ##
===========================================
- Coverage    78.71%   78.70%   -0.02%     
===========================================
  Files          947      948       +1     
  Lines       102411   102427      +16     
  Branches      8273     8272       -1     
===========================================
- Hits         80613    80611       -2     
- Misses       21798    21816      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit d60f645 into develop Nov 26, 2023
17 of 19 checks passed
@syuilo syuilo deleted the patch-3969 branch November 26, 2023 07:15
@syuilo
Copy link
Member

syuilo commented Nov 26, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optionally treat short silent videos as gifs
3 participants