Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verifymail.io APIの設定項目が反映されない #12399

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

nafu-at
Copy link
Contributor

@nafu-at nafu-at commented Nov 21, 2023

What

いつの間にか私のカスタマイズをチェリーピックしていただいていたのですが、バグったままマージされてしまったのでバグ修正のコミットです。

Why

このままでは設定後の値がリロード後に設定画面に反映されません。

Additional info (optional)

自環境で動作中

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b13179) 78.81% compared to head (1bb1f68) 78.63%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12399      +/-   ##
===========================================
- Coverage    78.81%   78.63%   -0.18%     
===========================================
  Files          949      176     -773     
  Lines       102919    23334   -79585     
  Branches      8278      495    -7783     
===========================================
- Hits         81111    18349   -62762     
+ Misses       21808     4985   -16823     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -358,6 +358,16 @@
                       "optional": false,
                       "nullable": false
                     },
+                    "enableVerifymailApi": {
+                      "type": "boolean",
+                      "optional": false,
+                      "nullable": false
+                    },
+                    "verifymailAuthKey": {
+                      "type": "string",
+                      "optional": false,
+                      "nullable": true
+                    },
                     "enableChartsForRemoteUser": {
                       "type": "boolean",
                       "optional": false,
@@ -480,6 +490,8 @@
                     "objectStorageSetPublicRead",
                     "enableIpLogging",
                     "enableActiveEmailValidation",
+                    "enableVerifymailApi",
+                    "verifymailAuthKey",
                     "enableChartsForRemoteUser",
                     "enableChartsForFederatedInstances",
                     "enableServerMachineStats",

Get diff files from Workflow Page

@syuilo syuilo merged commit 18bdec9 into misskey-dev:develop Nov 22, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 22, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants