Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): rename FunoutTimelineService to FanoutTimelineService #12453

Conversation

zyoshoka
Copy link
Contributor

What

FunoutTimelineService を FanoutTimelineService に改名しました。

Why

funout と fanout が混ざっていると紛らわしいためです。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 25, 2023
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (95095ee) 78.74% compared to head (ba901db) 78.73%.

Files Patch % Lines
packages/backend/src/core/NoteCreateService.ts 88.88% 2 Missing ⚠️
...kend/src/server/api/endpoints/channels/timeline.ts 66.66% 1 Missing ⚠️
...es/backend/src/server/api/endpoints/roles/notes.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12453      +/-   ##
===========================================
- Coverage    78.74%   78.73%   -0.01%     
===========================================
  Files          947      947              
  Lines       102905   102905              
  Branches      8292     8291       -1     
===========================================
- Hits         81028    81026       -2     
- Misses       21877    21879       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit 7a494b2 into misskey-dev:develop Nov 26, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 26, 2023

🙏

@zyoshoka zyoshoka deleted the rename-funout-timeline-service-to-fanout-timeline-service branch May 15, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants