enhance(frontend): ウィジェットを非表示にできるPageMetaを追加 #12456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12456 +/- ##
===========================================
- Coverage 78.81% 78.54% -0.27%
===========================================
Files 958 183 -775
Lines 104272 24122 -80150
Branches 8335 497 -7838
===========================================
- Hits 82177 18947 -63230
+ Misses 22095 5175 -16920 ☔ View full report in Codecov by Sentry. |
|
ページ側が自身が表示されることになる親UIについての情報を知っているというのは微妙だからneedWideAreaとかどうかしら |
|
👍🏻 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* (enhance) ウィジェットを非表示にできるPageMetaを追加 * fix lint * rename --------- Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
definePageMetadataでhideWidgetsが設定できるようになるtrueにすると、そのページではウィジェットが非表示になる（右下のボタンでドロワーとして表示できる）Why
横幅が必要なページをつくるときに楽
Additional info (optional)
Checklist