enhance(dev): 開発モード時にlocaleと型定義が自動的に再生成されるように #12481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hideki0403
changed the title
これは別に開発モードに限定する必要はなさそう（デフォルトで使えるようになってるサーバーもあるので） |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12481 +/- ##
===========================================
- Coverage 78.68% 78.30% -0.38%
===========================================
Files 951 178 -773
Lines 103427 23636 -79791
Branches 8328 496 -7832
===========================================
- Hits 81382 18509 -62873
+ Misses 22045 5127 -16918 ☔ View full report in Codecov by Sentry. |
|
変更しました:eyes: あと確認しておきたい所があって、 |
|
無くても問題なさそうなら無くて良さそう |
|
修正しました:pray: |
noridev
added a commit
to kokonect-link/cherrypick
that referenced
this pull request
Nov 29, 2023
|
👍 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* enhance: localeを任意のタイミングでリビルドできるように * enhance: localeも監視し、必要であればlocaleをリビルドするように * feat: devモードの時のみナビゲーションバーからキャッシュクリアができるように * refactor: キャッシュクリア部分を共通化 * fix: localesのファイル変更イベントが取れないのを修正 * fix: replaceAllでコケるのを修正 * change: 開発モードに関係なくナビゲーションバーからキャッシュクリアできるように * refactor: 必要のないリビルドをしないように * update: CHANGELOG.md --------- Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
開発モード(pnpm dev)で起動している場合に、localeディレクトリ内のymlが更新されたタイミングで型定義と各言語のlocaleが再生成されるようにしました。
またクライアントのナビゲーションバーに「キャッシュを削除」ボタンを表示および追加できるようにし、簡単に最新版のlocaleに更新できるようにしました。
Why
現状、以下のような問題が存在します。
Additional info (optional)
pnpm build-assets --watchが動作していなかった問題も修正しましたChecklist