Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): 翻訳のダブりを解消 #12519

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • 「キャッシュを削除」が追加されたが、「キャッシュをクリア」があるのでそちらを使用するようにした
  • MkLaunchpadのスタイル調整

Why

翻訳のダブり解消

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca424df) 78.64% compared to head (eb73688) 78.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12519      +/-   ##
===========================================
+ Coverage    78.64%   78.78%   +0.14%     
===========================================
  Files          950      952       +2     
  Lines       103297   103488     +191     
  Branches      8330     8357      +27     
===========================================
+ Hits         81238    81536     +298     
+ Misses       22059    21952     -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih changed the title fix(frontend): 翻訳のダブりを解消 refactor(frontend): 翻訳のダブりを解消 Nov 30, 2023
@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft November 30, 2023 07:04
@kakkokari-gtyih
Copy link
Contributor Author

同一キーを使っているものがないか再確認中

@kakkokari-gtyih
Copy link
Contributor Author

多分無いと思う

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review November 30, 2023 07:06
@syuilo syuilo merged commit b37e8ff into misskey-dev:develop Dec 2, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 2, 2023

👍

@kakkokari-gtyih kakkokari-gtyih deleted the fix-duplicate-translation-0 branch December 8, 2023 06:34
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants