enhance/feat(frontend): データセーバーの改良・強化 #12526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12526 +/- ##
===========================================
- Coverage 78.79% 78.42% -0.38%
===========================================
Files 953 180 -773
Lines 103748 23857 -79891
Branches 8348 495 -7853
===========================================
- Hits 81750 18709 -63041
+ Misses 21998 5148 -16850 ☔ View full report in Codecov by Sentry. |
kakkokari-gtyih
commented
Nov 30, 2023
Comment on lines
+26
to
+32
| // なんかtestがうまいこと動かないのでここに書く | ||
| dataSaver: { | ||
| media: false, | ||
| avatar: false, | ||
| urlPreview: false, | ||
| code: false, | ||
| }, |
There was a problem hiding this comment.
vitestが落ちるのでむりやり初期値を書いて回避しました
kakkokari-gtyih
changed the title
|
こんにちは。全て有効にする/全て無効にするボタンが4つのデータセーバーオプションのいずれかをオンまたはオフにしないと動作しないようですが、もしよろしければご確認いただけますか？ |
みてみます |
なおりました |
|
👍🏻 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* enhance(frontend): データセーバーを個別で設定できるように * Update Changelog * fix design * (fix) 設定が当たらない * fix test（無理やり感） * (fix) 設定がない状態ですべて有効・向操作が効かない * fix * tweak --------- Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
This was referenced Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Fix #12259
Fix #12435
Additional info (optional)
Checklist