feat: ユーザースキーマの改善 #12568
Merged
feat: ユーザースキーマの改善 #12568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12568 +/- ##
===========================================
+ Coverage 78.74% 78.76% +0.01%
===========================================
Files 954 955 +1
Lines 103825 103860 +35
Branches 8351 8327 -24
===========================================
+ Hits 81758 81806 +48
+ Misses 22067 22054 -13 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -63495,7 +63495,11 @@
},
"notify": {
"type": "string",
- "nullable": false
+ "nullable": false,
+ "enum": [
+ "normal",
+ "none"
+ ]
},
"withReplies": {
"type": "boolean",
@@ -63686,7 +63690,240 @@
},
"notificationRecieveConfig": {
"type": "object",
- "nullable": false
+ "nullable": false,
+ "properties": {
+ "app": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ },
+ "quote": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ },
+ "reply": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ },
+ "follow": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ },
+ "renote": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ },
+ "mention": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ },
+ "reaction": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ },
+ "pollEnded": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ },
+ "achievementEarned": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ },
+ "receiveFollowRequest": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ },
+ "followRequestAccepted": {
+ "type": "object",
+ "nullable": false,
+ "properties": {
+ "type": {
+ "type": "string",
+ "nullable": false,
+ "enum": [
+ "all",
+ "following",
+ "follower",
+ "mutualFollow",
+ "list",
+ "never"
+ ]
+ }
+ },
+ "required": [
+ "type"
+ ]
+ }
+ }
},
"emailNotificationTypes": {
"type": "array",
@@ -63858,7 +64095,29 @@
"nullable": false,
"items": {
"type": "object",
- "nullable": false
+ "nullable": false,
+ "properties": {
+ "id": {
+ "type": "string",
+ "nullable": false,
+ "format": "id",
+ "example": "xxxxxxxxxx"
+ },
+ "name": {
+ "type": "string",
+ "nullable": false
+ },
+ "lastUsed": {
+ "type": "string",
+ "nullable": false,
+ "format": "date-time"
+ }
+ },
+ "required": [
+ "id",
+ "name",
+ "lastUsed"
+ ]
}
}
}, |
👍🏻 |
|
了解しました。Misskey.jsの更新までするので少々お待ちください🙏 |
|
出来ました |
|
バックエンドの型チェックが失敗してるのが直れば良さそうです 👍🏻 |
|
直ったと思います |
|
🙏🙏 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* chore: notifyにenumを設定 * feat: securityKeysListの型を明確に * feat: notificationRecieveConfigにpropertiesを定義 * chore: misskey.jsのmodelを更新 * fix: as constをつけ忘れている
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
packedUserDetailedNotMeOnlySchema.notifyにenumを追加しましたpackedMeDetailedOnlySchema.securityKeysListにpropertiesを定義しましたWhy
現状だとドキュメントから
securityKeysListはobjectであることしか知ることが出来ない為。また、notifyにはどのような文字列が入るのか明確にするためAdditional info (optional)
現状は何も手を加えていませんが
notificationRecieveConfigにもpropertiesを定義したいと考えています。愚直に記述すると量がとても多いため、部分的に別の変数に分けてそれを使うようにしたいのですが、大丈夫でしょうか?以下がやりたい物になるので、大丈夫そうでしたらこちらもコミットしようと思います
Checklist