Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): pagination with sinceId broken #12586

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

anatawa12
Copy link
Member

What

#12564 (comment)

指摘の通り壊れていたので修正しました。

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (8866c53) 78.76% compared to head (d83bbf3) 78.79%.
Report is 3 commits behind head on develop.

Files Patch % Lines
.../backend/src/core/FanoutTimelineEndpointService.ts 75.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12586      +/-   ##
===========================================
+ Coverage    78.76%   78.79%   +0.03%     
===========================================
  Files          955      956       +1     
  Lines       103873   104054     +181     
  Branches      8337     8334       -3     
===========================================
+ Hits         81814    81991     +177     
- Misses       22059    22063       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@anatawa12
Copy link
Member Author

@syuilo #12507 でsinceIdのpagenationを壊してしまったので修正したので確認していただけないでしょうか

@syuilo syuilo merged commit 1d3ef7b into misskey-dev:develop Dec 7, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 7, 2023

🙏

@anatawa12 anatawa12 deleted the fix-fanout-timeline-sinceId branch December 23, 2023 14:59
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* fix(backend): pagination with sinceId broken

* fix(backend): pagination with sinceId broken for dbFallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants