fix(dev-frontend) 一部のアセットが読み込まれない問題を修正 #12604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkokari-gtyih
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12604 +/- ##
===========================================
+ Coverage 79.59% 81.58% +1.98%
===========================================
Files 959 184 -775
Lines 108253 28097 -80156
Branches 8337 497 -7840
===========================================
- Hits 86169 22922 -63247
+ Misses 22084 5175 -16909 ☔ View full report in Codecov by Sentry. |
|
（対応漏れ申し訳ない… 🙇♂️） |
|
ちょっと他にも色々おかしいところあったので別でPRたてます |
|
🙏 |
|
@samunohito （あと基本的にMisskeyはSquash and Mergeでマージします） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
/static-assetsと/client-assetsがプロキシから抜けていた（identiconを無効化していた際のフォールバックアバターが表示されなかったのを修正）
Why
Additional info (optional)
Checklist