Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/vue import error on intellij #12612

Merged

Conversation

samunohito
Copy link
Member

What

Intellij系IDEでは、vueファイルのimport箇所で「Cannot find module」とエラーが表示されてしまいます。

このimportエラーを解消するために、型定義ファイルを追加します。

※VSCodeではもともと起こっていません

Why

ビルド自体は出来るとはいえ、本来は起こらないエラーじゃので気持ち悪い

Additional info (optional)

VSCode側でエラーとならないこと、pnpm build && pnpm startでビルドしたものが動作することを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@samunohito samunohito added the 🛠️Dev Development of Misskey itself label Dec 9, 2023
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 9, 2023
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (319267e) 81.71% compared to head (9b1ed09) 81.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12612   +/-   ##
========================================
  Coverage    81.71%   81.71%           
========================================
  Files          184      184           
  Lines        28049    28049           
  Branches       497      497           
========================================
  Hits         22920    22920           
  Misses        5129     5129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit b7bdd45 into misskey-dev:develop Dec 9, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 9, 2023

👍🏻

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* Fix fix labeler config (misskey-dev#8)

* fix vue import error

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
@samunohito samunohito deleted the fix/vue-import-error-on-intellij branch January 11, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️Dev Development of Misskey itself packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants