fix(frontend): MkAnimBgをリサイズに対応させる #12642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkokari-gtyih
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12642 +/- ##
===========================================
- Coverage 79.69% 79.68% -0.01%
===========================================
Files 959 959
Lines 108404 108404
Branches 8351 8345 -6
===========================================
- Hits 86388 86380 -8
- Misses 22016 22024 +8 ☔ View full report in Codecov by Sentry. |
|
GLSL側に uniform vec2 u_resolution; として解像度渡してるから、それを参照してよしなにアスペクト比考慮するようにした方がシンプルに済むかも |
|
引き継ぎます |
|
あー勘違いしてた |
|
🙏🏻 🙏🏻 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* (fix) MkAnimBgをリサイズに対応させる * fix lint * refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Fix #12535
Additional info (optional)
Checklist