Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) デフォルト表示時のヘッダにあるチャンネルボタンが反応しない現象の修正 #12648

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

samunohito
Copy link
Member

What

#12647 の対応です。

Why

fix #12647

Additional info (optional)

ローカルで以下を確認

  • お気に入りチャンネルありのとき、チャンネル名と新規追加メニューの間に区切り線があること
  • お気に入りチャンネルなしのとき、チャンネル名と区切り線が表示されず、新規追加メニューのみが表示されること

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md ※ごく最近のコミットに対する修正なので記載していません
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (daea5a3) 79.67% compared to head (af70169) 81.89%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12648      +/-   ##
===========================================
+ Coverage    79.67%   81.89%   +2.22%     
===========================================
  Files          959      184     -775     
  Lines       108410    28238   -80172     
  Branches      8350      503    -7847     
===========================================
- Hits         86373    23125   -63248     
+ Misses       22037     5113   -16924     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samunohito samunohito marked this pull request as ready for review December 13, 2023 22:17
@syuilo syuilo merged commit eeed67e into misskey-dev:develop Dec 13, 2023
9 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 13, 2023

🙏

@samunohito
Copy link
Member Author

はやい

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
@samunohito samunohito deleted the fix/12647_invalid_null_item branch January 11, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

デフォルト表示時のヘッダにあるチャンネルボタンが反応しない
2 participants