-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): 絵文字ピッカー設定ページのボタン文言修正 #12676
fix(frontend): 絵文字ピッカー設定ページのボタン文言修正 #12676
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12676 +/- ##
========================================
Coverage 79.64% 79.64%
========================================
Files 955 955
Lines 107678 107678
Branches 8349 8351 +2
========================================
+ Hits 85757 85764 +7
+ Misses 21921 21914 -7 ☔ View full report in Codecov by Sentry. |
(vitestが死んでるのはリリース用プルリクと同件かしら…) |
locales/ja-JP.yml
Outdated
copyFromPinnedEmojisForReaction: "リアクション設定からコピーする" | ||
copyFromPinnedEmojis: "絵文字設定からコピーする" | ||
copyFromPinnedEmojisForReaction: "リアクション設定から上書きする" | ||
copyFromPinnedEmojis: "全般設定から上書きする" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
キー名も overwrite に変えた方が良さそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なおしました 🙏
🙏🏻 |
* fix(frontend): 絵文字ピッカー設定ページのボタン文言修正 * fix
What
#12669 をご参照ください。
Why
fix #12669
Additional info (optional)
pnpm build && pnpm start にて文言を表示確認
Checklist